Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Focus executions iframe when n8n is ready to delegate keyboard events #12741

Merged

Conversation

alexgrozav
Copy link
Member

Summary

Screen.Recording.2025-01-21.at.10.23.06.mov

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-456/cannot-pan-canvas-in-an-execution-until-after-first-interaction

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Jan 21, 2025
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

ivov
ivov previously approved these changes Jan 27, 2025
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

Copy link

cypress bot commented Jan 27, 2025

n8n    Run #8994

Run Properties:  status check passed Passed #8994  •  git commit 3400f75a58: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-456-cannot-pan-canvas-in-an-execution-until-after-first
Run status status check passed Passed #8994
Run duration 04m 24s
Commit git commit 3400f75a58: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit d506218 into master Jan 28, 2025
38 checks passed
@alexgrozav alexgrozav deleted the cat-456-cannot-pan-canvas-in-an-execution-until-after-first branch January 28, 2025 15:22
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
@janober
Copy link
Member

janober commented Jan 29, 2025

Got released with n8n@1.77.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants