INC-31: Refactor the kube_pod_info label merging for all PrometheusRules
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the label merge for kube_pod_info to group by on only required information, which should remove potential duplicate entries on the left-hand-side of the group_left query. This will resolve when the kube-state-metrics service is restarted due to Node or Deployment upgrade which results in new values for some labels, including instance, which breaks the mappings.
jonathanio
added
priority/high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the label merge for
kube_pod_infotogroup by() ()on only required information, which should remove potential duplicate entries on the left-hand side of thegroup_leftquery. This will resolve when thekube-state-metricsservice is restarted due to aNodeorDeploymentupgrade, which results in new values for some labels, includinginstance, which breaks the mappings.Checklist
Please check and confirm the following items have been performed, where
possible, for this Pull Request:
type/...,changes/..., and 'release/...' labels, as needed.