[agroal#504] Optimize SALT

We do this by removing the independent HMAC context initializations from the HMAC iterations present in salted_password Signed-off-by: Yassin ElBedwihy <eng.yassin.elbedwihy@gmail.com>
n0rbed · Mar 2, 2025 · 1d52ec5 · 1d52ec5
1 parent 400e019
commit 1d52ec5
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -16,3 +16,4 @@ Haoran Zhang <andrewzhr9911@gmail.com>
 Mohanad Khaled <mohanadkhaled87@gmail.com>
 Christian Englert <code@c.roboticbrain.de>
 Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
+Yassin ElBedwihy <eng.yassin.elbedwihy@gmail.com>
diff --git a/doc/manual/97-acknowledgement.md b/doc/manual/97-acknowledgement.md
@@ -23,6 +23,7 @@ Mohanad Khaled <mohanadkhaled87@gmail.com>
 Haoran Zhang <andrewzhr9911@gmail.com>
 Christian Englert <code@c.roboticbrain.de>
 Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
+Yassin ElBedwihy <eng.yassin.elbedwihy@gmail.com>
 ```
 
 ## Committers

diff --git a/doc/manual/advanced/97-acknowledgement.md b/doc/manual/advanced/97-acknowledgement.md
@@ -23,6 +23,7 @@ Mohanad Khaled <mohanadkhaled87@gmail.com>
 Haoran Zhang <andrewzhr9911@gmail.com>
 Christian Englert <code@c.roboticbrain.de>
 Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
+Yassin ElBedwihy <eng.yassin.elbedwihy@gmail.com>
 ```
 
 ## Committers

diff --git a/src/libpgagroal/security.c b/src/libpgagroal/security.c
@@ -3824,17 +3824,18 @@ salted_password(char* password, char* salt, int salt_length, int iterations, uns
    }
    memcpy(r, &Ui_prev[0], size);
 
-   for (int i = 2; i <= iterations; i++)
+   if (HMAC_CTX_reset(ctx) != 1)
    {
-      if (HMAC_CTX_reset(ctx) != 1)
-      {
-         goto error;
-      }
+      goto error;
+   }
 
-      if (HMAC_Init_ex(ctx, password, password_length, EVP_sha256(), NULL) != 1)
-      {
-         goto error;
-      }
+   if (HMAC_Init_ex(ctx, password, password_length, EVP_sha256(), NULL) != 1)
+   {
+      goto error;
+   }
+
+   for (int i = 2; i <= iterations; i++)
+   {
 
       if (HMAC_Update(ctx, &Ui_prev[0], size) != 1)
       {