[#8181] Fix attachment blob integrity error #8182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to persist the attachment blob as the checksum and byte size can change after masking.
Fix existing integrity errors preventing mirroring of attachments to the secondary storage services.
gbp
force-pushed
the
8181-fix-blob-integrity-error
branch
from
cf6a964 to
98fc493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #8181
What does this do?
Fix attachment blob integrity error
Why was this needed?
Error introduced in #8125 which meant the on disk attachment could be updated but the checksum wasn't which means
ActiveStorage::IntegrityErrorcan be raised. This happens when running the storage mirror task and probably at other times too.Implementation notes
Change to the task only need to be temporary until attachments are mirrored.
[skip changelog] - not needed as fix for unreleased change