Refactor spec configuration option assignment #8152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some spec examples require certain configuration options to be set, this commit switches to stubbing the option instead of reassigning the option to the required value to get the test to pass. This means we don't need to revert the value after the test example has been run back to the original value.
|
nice ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Refactor spec configuration option assignment
Why was this needed?
Some spec examples require certain configuration options to be set, this commit switches to stubbing the option instead of reassigning the option to the required value to get the test to pass.
This means we don't need to revert the value after the test example has been run back to the original value.
[skip changelog]