Refactor localised admin forms #8150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce indentation which will make future commit diffs clearer.
Use existing locale_fields partial with minor changes as this needs to work within the `translated_fields` form builder helper.
Use our `translated_form_for` helper and `translated_fields` form build helper so we don't have to manually create the locale tabbed interface for translated form fields.
Need to call `#build_all_translations` so the form is re-rendered correctly after validation errors.
Use translated_form_for error_messages helper to generate list of issues stopping the form from being submitted.
|
Haven't checked thoroughly but looks good in principle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Refactor localised admin forms
Why was this needed?
To reduce complexity and make the forms consistent with each other.
Implementation notes
Switches admin forms with translated fields to use the
translated_form_forform builder andtranslated_fieldsform helper. Means we don't have to manually build the tabbed interface for the different locales in use.This is already in use for the
OutgoingMessage::Snippetforms and can be re-used forAnnouncementCategory,PublicBodyandNoteforms.[skip changelog]