Update attachment body assignment #8125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When masking attachments avoid replacing the blob with a new blob, instead update which retains the blob key and existing metadata. This means no `ActiveStorage::PurgeJob` or an additional `ActiveStorage::AnalyzeJob` for the new blob.
|
Everything is working as expected on staging with this change. |
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Update attachment body assignment
Why was this needed?
When masking attachments avoid replacing the blob with a new blob, instead update which retains the blob key and existing metadata.
This means no
ActiveStorage::PurgeJobor an additionalActiveStorage::AnalyzeJobfor the new blob.