Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add private endpoints #144

Merged
merged 7 commits into from
Dec 18, 2023
Merged

feat: add private endpoints #144

merged 7 commits into from
Dec 18, 2023

Conversation

Cysword
Copy link
Contributor

@Cysword Cysword commented Dec 8, 2023

Add endpoints:

  • account messages
  • accounts
  • api-key
  • carrier-options
  • locations
  • shipments
  • shops
  • subscriptiopn-capabilities
  • subscriptions
  • system-country-codes
  • track traces
  • webhook subscriptions

@Cysword Cysword requested review from a team as code owners December 8, 2023 12:41
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (ad1f64f) 92.47% compared to head (e8f9f6b) 94.31%.
Report is 1 commits behind head on main.

Files Patch % Lines
...s/private/account-messages/DeleteAccountMessage.ts 95.00% 0 Missing and 1 partial ⚠️
...nts/private/account-messages/GetAccountMessages.ts 95.23% 0 Missing and 1 partial ⚠️
src/endpoints/private/accounts/GetAccount.ts 95.00% 0 Missing and 1 partial ⚠️
src/endpoints/private/accounts/PutAccount.ts 94.73% 0 Missing and 1 partial ⚠️
src/endpoints/private/api-key/GetApiKeys.ts 94.11% 0 Missing and 1 partial ⚠️
src/endpoints/private/api-key/PostApiKeys.ts 95.00% 0 Missing and 1 partial ⚠️
...ts/private/carrier-options/DeleteCarrierOptions.ts 95.23% 0 Missing and 1 partial ⚠️
...oints/private/carrier-options/GetCarrierOptions.ts 94.44% 0 Missing and 1 partial ⚠️
...ints/private/carrier-options/PostCarrierOptions.ts 94.44% 0 Missing and 1 partial ⚠️
src/endpoints/private/locations/GetLocations.ts 93.33% 0 Missing and 1 partial ⚠️
... and 11 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   92.47%   94.31%   +1.83%     
==========================================
  Files          42       83      +41     
  Lines        1170     1918     +748     
  Branches       88      109      +21     
==========================================
+ Hits         1082     1809     +727     
- Partials       88      109      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fleurvaneijk
fleurvaneijk requested changes Dec 15, 2023
View reviewed changes
src/endpoints/endpoints.spec.ts Show resolved Hide resolved
src/endpoints/private/accounts/PutAccount.ts Outdated Show resolved Hide resolved
src/endpoints/private/carrier-options/PostCarrierOptions.ts Outdated Show resolved Hide resolved
@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Dec 15, 2023
@Cysword Cysword requested a review from fleurvaneijk December 18, 2023 07:50
@myparcel-bot myparcel-bot bot removed the changes requested (Auto) label Dec 18, 2023
@myparcel-bot myparcel-bot bot added the approved (Auto) label Dec 18, 2023
EdieLemoine
EdieLemoine approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super dat je die doc links hebt bijgewerkt 🙏🏼

@EdieLemoine EdieLemoine added this pull request to the merge queue Dec 18, 2023
Merged via the queue into main with commit aed019f Dec 18, 2023
8 checks passed
@EdieLemoine EdieLemoine deleted the feat/add-private-endpoints branch December 18, 2023 10:23
MyParcelBot pushed a commit that referenced this pull request Dec 19, 2023
@semantic-release-bot
chore(release): 3.4.0 [skip ci]
e948c1d 
## [3.4.0](v3.3.1...v3.4.0) (2023-12-19)

### ✨ New Features

* add private endpoints ([#144](#144)) ([aed019f](aed019f))
* return all content in data when no response property is defined ([#145](#145)) ([5b6e274](5b6e274))

### 🐛 Bug Fixes

* add missing exports for endpoints ([#146](#146)) ([b3a349f](b3a349f))
@MyParcelBot
Copy link

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcohendriks remcohendriks remcohendriks approved these changes

@EdieLemoine EdieLemoine EdieLemoine approved these changes

@fleurvaneijk fleurvaneijk fleurvaneijk approved these changes

Assignees

@Cysword Cysword

Labels
approved (Auto) released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cysword @MyParcelBot @remcohendriks @EdieLemoine @fleurvaneijk