1.4.3 <=> IMDB ID cleaning to minimize amount of non-matches

mynttt · Aug 25, 2020 · 394a1ec · 394a1ec
1 parent 74a26bc
commit 394a1ec
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 1.4.3
+- IMDB id cleaning to minimize the amount of non matches after having an id resolved
+
 ## 1.4.2
 - tmdb resolve bug fixed
 

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-1.4.1
+1.4.3
diff --git a/build.gradle b/build.gradle
@@ -5,7 +5,7 @@ plugins {
     id 'com.github.spotbugs' version '2.0.1'
 }
 
-version = '1.4.2'
+version = '1.4.3'
 sourceCompatibility = '11'
 
 new File(projectDir, "VERSION").text = version;

diff --git a/src/main/java/updatetool/imdb/ImdbPipeline.java b/src/main/java/updatetool/imdb/ImdbPipeline.java
@@ -147,7 +147,7 @@ public void accumulateMetadata(ImdbJob job) throws Exception {
     @Override
     public void transformMetadata(ImdbJob job) throws Exception {
         var map = new HashMap<ImdbMetadataResult, ExportedRating>();
-        job.items.forEach(i -> map.put(i, dataset.getRatingFor(i.imdbId)));
+        job.items.forEach(i -> map.put(i, dataset.getRatingFor(ImdbTransformer.clean(i.imdbId))));
         var noUpdate = map.entrySet().stream().filter(Predicate.not(ImdbTransformer::needsUpdate)).collect(Collectors.toSet());
         if(!noUpdate.isEmpty()) {
             Logger.info(noUpdate.size() + " item(s) need no update.");

diff --git a/src/main/java/updatetool/imdb/ImdbRatingDatasetFactory.java b/src/main/java/updatetool/imdb/ImdbRatingDatasetFactory.java
@@ -37,7 +37,7 @@ public static class ImdbRatingDataset {
         private HashMap<String, String> data = new HashMap<>();
 
         public ExportedRating getRatingFor(String imdbId) {
-            final String rating = data.get(imdbId);
+            String rating = data.get(imdbId);
             return () -> rating;
         }
     }

diff --git a/src/main/java/updatetool/imdb/ImdbTransformer.java b/src/main/java/updatetool/imdb/ImdbTransformer.java
@@ -77,4 +77,12 @@ public static void updateMetadata(Map.Entry<ImdbMetadataResult, ExportedRating>
 
         meta.extraData = extra.toURI();
     }
+
+    // Cleaning required because of interesting data from TVDB
+    public static String clean(String imdbId) {
+        if(imdbId == null)
+            return null;
+        String numbers = ImdbUtility.extractId(ImdbUtility.NUMERIC, imdbId);
+        return "tt"+numbers;
+    }
 }
diff --git a/src/main/resources/VERSION b/src/main/resources/VERSION
@@ -1 +1 @@
-1.4.1
+1.4.3