Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tail call optimization in sse/server.ex #61

Open
vjebelev opened this issue Apr 23, 2020 · 1 comment
Open

No tail call optimization in sse/server.ex #61

vjebelev opened this issue Apr 23, 2020 · 1 comment

Comments

@vjebelev
Copy link

This method: listen_sse is called recursively but it's not tail-call optimized, so the stack size grows with each sent chunk. For long / active SSE connections this will cause issues. Removing returning conn in that method fixes the issue.

@mustafaturan
Copy link
Owner

right, will be working on it soon. tx for bringing it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants