Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update jekyll build workflow #738

Merged

Conversation

musicEnfanthen
Copy link
Member

This PR updates the Jekyll build workflow, according to the following sources:

This also requires the settings to be updated to "Change Source under Build and deployment from Deploy from a branch to GitHub Actions."

However, there is neither a guarantee nor a way to test whether this modified workflow works. So please proceed with caution.

@musicEnfanthen musicEnfanthen requested a review from bwbohl February 1, 2025 21:56
Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you try it on your fork?

@musicEnfanthen
Copy link
Member Author

No, I couldn't. Not sure where it gets deployed to because of the CNAME.

@musicEnfanthen musicEnfanthen requested a review from lpugin February 5, 2025 10:26
@lpugin lpugin merged commit dfffa4f into music-encoding:main Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants