Correct measure width when following begins with clef, key or time sig #26806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
reviewed
Feb 27, 2025
| double segWidth = curSegMeasure == nextSegMeasure || nextSeg->isStartRepeatBarLineType() ? nextX - curX : curSeg->minRight(); | ||
| double segWidth = curSegMeasure == nextSegMeasure || nextSeg->isStartRepeatBarLineType() | ||
| || nextSeg->isKeySigType() || nextSeg->isTimeSigType() | ||
| || nextSeg->isClefType() ? nextX - curX : curSeg->minRight(); |
There was a problem hiding this comment.
This is unreadable now though. Perhaps a bool computeWidthByDifferenceFromNext or something like that could help
miiizen
force-pushed
the
26780-non-cr-start
branch
from
5a633e2 to
37ffb28
Compare
oktophonie
approved these changes
Feb 28, 2025
mike-spa
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26780
In this situation, the first segment of the measure is a key signature.
We should set the width of the preceding chordrest segment by using the difference between the next segment position and this segment's position. Otherwise, the start of the measure is placed well before the position of it's first segment, the key signature.
This case was already handled for start repeat barlines, I have just extended it to cover clefs, key and time signatures.