Percussion panel - fix drum note input when switching voices

[mathesoncalum]

The change to the percussion panel's writePitch method introduced with b322781 means that we now go through cmdAddPitch when writing notes. This method contains some old logic for evaluating segments on percussion staves which is now redundant after 9dcbfac (see handleOverlappingChordRest).

[zacjansheski]

There is some weirdness switching voices on tuplets (I would expect the second note to go to the second partial of the triplet even if it is in the other voice)

Actually this is also an issue with mouse input already...

video1805558207.mp4

[zacjansheski]

This could also be more problematic than we initially thought. If the second note is in voice two, the beginning of the bar does not contain a rest. It can be a pain to get a (desired) rest there

[zacjansheski]

@bkunda we might want to call an audible on this.
A good exercise is to try writing music like this (sorry for the bad image)

[mathesoncalum]

Thanks @zacjansheski - I’ve pushed some changes that should improve the situation with tuplets.



In our general note input we have some logic for when the user actively switches voices in the middle of the tuplet - this just wasn’t getting called in this case (because the voice switches automatically). 
The latest changes ensure that this logic runs when alternating voices in percussion staves as described above.








That said, it isn’t a perfect solution. This goes back to #24948 where the decision was made to move the cursor to the beginning of a tuplet if the user tries to switch voices mid-tuplet. Providing real support for mid-tuplet voice switching is unlikely to be a trivial undertaking.

[zacjansheski]

Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved