Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align text from textlines in skyline #26772

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Feb 26, 2025

Resolves: #26462
Text from textlines wasn't being found in the skyline, as its shape contains a Text* pointer, not a HairpinSegment*. Check if the text is associated with a line and use that for comparison instead.

@miiizen miiizen requested a review from oktophonie February 26, 2025 16:17
@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label Feb 26, 2025
@miiizen miiizen merged commit b98d737 into musescore:master Feb 26, 2025
10 of 11 checks passed
@miiizen miiizen mentioned this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collision prevention does not trigger under certain conditions
3 participants