26665: Toolbar buttons do not react to long clicks

[krasko78]

Resolves: #26665

This is the same issue as #16012. The fix done there appears not to have fixed it. Handling the pressAndHold signal, even directly as implemented in the fix, suppresses the click signal.

I have found a new fix: when handling the pressAndHold signal, if we do not consume it, we should set the accepted property of the mouse event to false. In this case the click event will not be suppressed. Interestingly, for pressAndHold the accepted property is true by default which means the event has to be unaccepted if not consumed. So I am reverting the fix for #16012 and am taking care of the accepted property: in FlatButton I set accepted to false to not suppress the click signal if there are no handlers or none consumes the event. On the other hand, when pressAndHold is consumed in NoteInputBar and StyledToolBarItem, accepted will be set to true.

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[cbjeukendrup]

I'm not convinced that the changes in FlatButton are necessary; most FlatButtons, where there is no connection to the pressAndHold signal, react to long clicks just fine.
For performance, it is beneficial not to connect to pressAndHold when not necessary: I once looked at the Qt source code and saw that some logic is disabled when there are no connections to that signal.

In StyledToolBarItem and NoteInputBar, you could do the following:

    mouseArea.onPressAndHold: function (event) {
        if (menuLoader.isMenuOpened || !root.hasMenu) {
            event.accepted = false;
            return
        }

        root.toggleMenuOpened()
    }

So, essentially the problem is that Connections with enabled: false is apparently not the same as not connecting to the signal at all; it is still seen as a connection. Therefore, we can just as well connect to the signal directly, without Connections. To still prevent the clicked event from being swallowed, we can indeed set accepted to false.

[krasko78]

Initially I had made it like what you are suggesting but thought: "nah, they'll probably suggest reverting it to the way it used to be". 😃 What you are saying makes sense to me. Press and hold needs a timer so likely this is optimized and not wasted if there are no connections. I'll change it. Thanks!

[krasko78]

There we go!

[cbjeukendrup]

Thanks!

[zacjansheski]

Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved
#26665 FIXED