Fix MSVC compiler warning #26656
Merged
Fix MSVC compiler warning #26656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jojo-Schmitz
commented
Feb 21, 2025
•
Jojo-Schmitz
commented
- reg.: conversion from 'size_t' to 'int', possible loss of data (C4267) (so far) master only
- reg.: declaration of 'playback' hides class member (C4458) master and 4.5.0 (merged in 4.5.0 already, see 4.5.0: Fix MSVC compiler warning #26763)
- reg.: 'isLayerVisible': unreferenced function with internal linkage has been removed (C4505) master and 4.5.0
- reg.: declaration of 'ctx' hides previous local declaration master and 4.5.0
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
8 times, most recently
from
3efbfc3 to
6987e38
Compare
reg.: 'initializing': conversion from 'size_t' to 'int', possible loss of data (C4267)
reg.: declaration of 'playback' hides class member (C4458)
reg.: 'isLayerVisible': unreferenced function with internal linkage has been removed (C4505)
reg.: declaration of 'ctx' hides previous local declaration
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
from
6987e38 to
2299b61
Compare
RomanPudashkin
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.