-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiplication sign for time signatures #26107
base: master
Are you sure you want to change the base?
Conversation
Can't that get extended to also allow |
@@ -1183,6 +1183,9 @@ SymIdList timeSigSymIdsFromString(const String& string, TimeSigStyle timeSigStyl | |||
{ 162, SymId::timeSigCutCommon }, // '¢' | |||
{ 189, SymId::timeSigFractionHalf }, | |||
{ 188, SymId::timeSigFractionQuarter }, | |||
{ 88, SymId::timeSigMultiply }, // 'X' | |||
{ 120, SymId::timeSigMultiply }, // 'x' | |||
{ 215, SymId::timeSigMultiply }, // '×' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any special reason why not using the characters themselves rather than their ASCII code?
As far as I can tell Char(88)
is the same as Char('X')
, except the latter is more readable (and obsolets the comment)
Or Char(u'×')
, etc.
I think those are for compound meters like "3/4= 6/8" and shouldn't turn up in this context. |
This comment was marked as resolved.
This comment was marked as resolved.
I believe similar additions are needed here:
to be able to actually enter those new signs |
@Jojo-Schmitz interestingly the time signature dialog you open from the palettes is not limited by a similar expression. |
But the timesig created with it is! It lacks those symbols. See also my backport to Mu3, Jojo-Schmitz#765 |
Backport of musescore#26107 plus some more (-, / =)
This PR makes the multiplication sign for time signatures available:
Upper and lower case X may be used as well as the multiplication character (
×
) ×.