Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when moving the end of the Ritardando that spans two lines on the score #26690

Closed
4 tasks done
mercuree opened this issue Feb 23, 2025 · 3 comments · Fixed by #26732
Closed
4 tasks done

Crash when moving the end of the Ritardando that spans two lines on the score #26690

mercuree opened this issue Feb 23, 2025 · 3 comments · Fixed by #26732
Assignees
Labels
crash Issues involving a crash of MuseScore P0 Priority: Critical regression MS4 Regression on a prior release

Comments

@mercuree
Copy link
Contributor

mercuree commented Feb 23, 2025

Issue type

Crash or freeze

Description with steps to reproduce

  1. Create empty score from Treble clef template
  2. Add a Ritardando line to the end of the second system (Second system is important) and extend it into the third system.
  3. Using mouse move the end of the marking on the third staff back to the second staff
  4. Crash
  • Other Gradual Tempo change elements are affected
  • Some lines are affected too. I checked trill line, ottava, cresc.
  • Regression since Musescore 4.4.1

Supporting files, videos and screenshots

crash_multiline_elements.mp4

What is the latest version of MuseScore Studio where this issue is present?

MuseScore Studio version (64-bit): 4.6.0-250540307, revision: github-musescore-musescore-9033dc2

Regression

Yes, this used to work in a previous version of MuseScore 4.x
(did not crash in 4.4.0; crashes since 4.4.1)

Operating system

windows 10

Additional context

This issue is based on a report from https://musescore.org/en/node/375475 and comment by @cadiz1

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@muse-bot muse-bot added crash Issues involving a crash of MuseScore regression MS4 Regression on a prior release labels Feb 23, 2025
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 23, 2025

It apparently crashes in isLineSegment(), I suspect gradual tempo change segments are not handled there.
It probably should have gone to isTextLineBaseSegment() instead?

@cbjeukendrup
Copy link
Contributor

Problem seems rather that it's calling Spanner::backSegment() while m_segments is empty.

@cbjeukendrup cbjeukendrup added regression nightly Works correctly in the latest released version and is broken in the nightly builds and removed regression MS4 Regression on a prior release labels Feb 24, 2025
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 24, 2025

Issue is since 4.4.1 already, so not regression of nightlies

@oktophonie oktophonie added regression MS4 Regression on a prior release and removed regression nightly Works correctly in the latest released version and is broken in the nightly builds labels Feb 24, 2025
@bkunda bkunda moved this to To do in MuseScore Studio 4.5 Feb 24, 2025
@bkunda bkunda added the P0 Priority: Critical label Feb 24, 2025
@mike-spa mike-spa moved this from To do to In Progress in MuseScore Studio 4.5 Feb 25, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Needs porting in MuseScore Studio 4.5 Feb 25, 2025
@RomanPudashkin RomanPudashkin moved this from Needs porting to Done in MuseScore Studio 4.5 Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Issues involving a crash of MuseScore P0 Priority: Critical regression MS4 Regression on a prior release
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

10 participants