Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Hiding top note of a chord on extra staff line causes every extra staff line to be hidden #14994

Open
LuisLiszt opened this issue Dec 6, 2022 · 5 comments
Labels
engraving needs design Design is needed P1 Priority: High

Comments

@LuisLiszt
Copy link

Describe the bug
See screenshot. When you hide a note of chord the "extra staff lines" will get invisible, causing the visible notes to "fly" above the staff.

To Reproduce
Steps to reproduce the behavior:

  1. Place a chord with notes above the usual staff.
  2. Hide a note thats ON a extra staff line.
  3. See the bug.

Expected behavior
Only the extra lines which are not needed to display the whole visible chord should be invisible.

Screenshots
Top note hidden:

Screenshot 2022-12-06 181121

Additional Context
Doing this is needed for something like this: https://musescore.org/de/node/277181 .
This is also a problem in MS3, so I think MS4 should make it better. Also the stem, which connects the top note with the rest of the chord should get invisible, so theres no rest of a stem on the final sheet.
Workaround to this bug was to just place the note in the second voice and hide it. However I think fixing this will improve user experience.

@MarcSabatella
Copy link
Contributor

MarcSabatella commented Dec 6, 2022

This has been debated in the past, with use cases existing for either behavior. Not so much for full chords, but for single notes. Probably there really needs to be a "show ledger lines" checkbox for chords to handle all cases.

This particular use case, though - creating a fake note for trill purposes - is better solved right now using a separate voice. Eventually of course, better still if trills supported accidentals directly.

@LuisLiszt

This comment was marked as off-topic.

@oktophonie oktophonie added the needs design Design is needed label Feb 21, 2023
@oktophonie oktophonie self-assigned this Feb 21, 2023
@oktophonie oktophonie added the P2 Priority: Medium label Feb 21, 2023
@oktophonie oktophonie changed the title [MU4 Issue] (RC) Hiding top note of a chord on extra staff line causes every extra staff line to be hidden [MU4 Issue] Hiding top note of a chord on extra staff line causes every extra staff line to be hidden Feb 28, 2023
@oktophonie oktophonie added engraving P1 Priority: High and removed P2 Priority: Medium labels Feb 28, 2023
@oktophonie
Copy link
Contributor

See also the related #16665

As discussed in several other places, we should implement options (which can be specified for each chord - or, arguably, for each note) for how to treat the hiding or showing of ledger lines:

  • hide all
  • show all
  • show only for visible notes

And, which is connected, we should be able to specify for any given chord whether its stem should extend to include invisible notes or not.

@worldwideweary
Copy link
Contributor

worldwideweary commented Oct 30, 2023

There's also the question of the stem - extending to the hidden note or not. Personally would never want that, nor desire hidden ledger lines to be hidden within the domain of visible notes. Example from personal build (purple is invisible):

image

Slight issue there though is not showing a second "invisible" stem when showing hidden stuff on score, but that could be done by drawing an extra stem-line between cut-off and extreme-point as invisible). Worth mentioning for whomever might implement that in version 4...

@Jojo-Schmitz
Copy link
Contributor

Came up again in https://musescore.org/en/node/369555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving needs design Design is needed P1 Priority: High
Projects
Status: Some release after that
Development

No branches or pull requests

5 participants