Skip to content

Commit

Permalink
Flip the order of target_include_directories and target_link_librarie…
Browse files Browse the repository at this point in the history
…s to clarify why include directories are being automatically added when adding libraries
  • Loading branch information
francesco-ballarin committed Nov 26, 2023
1 parent 3662408 commit df1fe27
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions multiphenicsx/cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -93,16 +93,17 @@ nanobind_add_module(
multiphenicsx/wrappers/multiphenicsx.cpp
)

# Add current source directory to include directories
target_include_directories(multiphenicsx_cpp PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
# Add DOLFINx C++ libraries
target_link_libraries(multiphenicsx_cpp PRIVATE dolfinx)

# Add DOLFINx, petsc4py and mpi4py include directories
# Add DOLFINx python, petsc4py and mpi4py include directories
# (with DOLFINx C++ ones already being added by target_link_libraries)
target_include_directories(multiphenicsx_cpp PRIVATE ${DOLFINX_PY_WRAPPERS_DIR})
target_include_directories(multiphenicsx_cpp PRIVATE ${PETSC4PY_INCLUDE_DIR})
target_include_directories(multiphenicsx_cpp PRIVATE ${MPI4PY_INCLUDE_DIR})

# Add DOLFINx libraries
target_link_libraries(multiphenicsx_cpp PRIVATE dolfinx)
# Add current source directory to include directories
target_include_directories(multiphenicsx_cpp PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})

# Install the compiled library to the cpp subdirectory
set_target_properties(multiphenicsx_cpp PROPERTIES INSTALL_RPATH_USE_LINK_PATH TRUE)
Expand Down

0 comments on commit df1fe27

Please sign in to comment.