Refactor DisconnectingState::handle_commands

[Serock3]

Refactor DisconnectingState::handle_commands to reduce code duplication.

---

This change is 

[dlon]

Very nice cleanup!

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion

---

talpid-core/src/tunnel_state_machine/disconnecting_state.rs line 60 at r1 (raw file):

            Some(TunnelCommand::Connectivity(connectivity)) => {
                shared_values.connectivity = connectivity;
                if !connectivity.is_offline() {

I think the logic was modified a bit here: If connectivity.is_offline() && matches!(_, AfterDisconnect::Reconnect(_)), should it not switch to AfterDisconnect::Block(_)?

[dlon]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Serock3)

[Serock3]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @dlon)

---

talpid-core/src/tunnel_state_machine/disconnecting_state.rs line 60 at r1 (raw file):

Previously, dlon (David Lönnhager) wrote…

I think the logic was modified a bit here: If connectivity.is_offline() && matches!(_, AfterDisconnect::Reconnect(_)), should it not switch to AfterDisconnect::Block(_)?

Good catch!

[dlon]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved