Remove references to Google in UI #7557
Conversation
pinkisemils
requested review from
faern,
MarkusPettersson98 and
albin-mullvad
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved
|
@pinkisemils I believe you're looking for this line: Do you want me to push a commit? 🙂 |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 21 of 21 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r2 (raw file):
If you are not connected to our VPN, then the Encrypted DNS proxy will use your own non-VPN IP \ when connecting. The DoH servers are hosted by one of the following providers: Quad9, Cloudflare.
nit: not consistent with the desktop/android string. Is that intentional? Otherwise we should probably align them 🙂
Quad9, Cloudflare vs. Quad9 or Cloudflare
Code quote:
Quad9, CloudflareThere was a problem hiding this comment.
Reviewed 1 of 21 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
pinkisemils
force-pushed
the
remove-google-from-default-resolvers-ui
branch
from
fbc6f41 to
a8a41ad
Compare
There was a problem hiding this comment.
Reviewed 23 of 23 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewable status:
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r2 (raw file):
Previously, albin-mullvad wrote…
nit: not consistent with the desktop/android string. Is that intentional? Otherwise we should probably align them 🙂
Quad9, Cloudflarevs.Quad9 or Cloudflare
Should be consistent now :)
There was a problem hiding this comment.
Reviewable status:
pinkisemils
force-pushed
the
remove-google-from-default-resolvers-ui
branch
from
a8a41ad to
fbc6f41
Compare
There was a problem hiding this comment.
Reviewed 22 of 23 files at r4, all commit messages.
Reviewable status: 22 of 23 files reviewed, 1 unresolved discussion
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r4 (raw file):
If you are not connected to our VPN, then the Encrypted DNS proxy will use your own non-VPN IP \ when connecting. The DoH servers are hosted by one of the following providers: Quad9, Cloudflare.
Was this revert intentional? 🤔
Code quote:
Quad9, Cloudflare
There was a problem hiding this comment.
Reviewable status: 22 of 23 files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r4 (raw file):
Previously, albin-mullvad wrote…
Was this revert intentional? 🤔
I also just realized we write "Quad9" here but "Quad 9" with a space in other places
pinkisemils
force-pushed
the
remove-google-from-default-resolvers-ui
branch
from
fbc6f41 to
33b0a52
Compare
There was a problem hiding this comment.
Reviewable status: 22 of 23 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r4 (raw file):
Previously, albin-mullvad wrote…
I also just realized we write "Quad9" here but "Quad 9" with a space in other places
No, it was the result of a faulty rebase :( Should be fixed now - thank you for being diligent here :)
There was a problem hiding this comment.
Reviewed 23 of 23 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r4 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
No, it was the result of a faulty rebase :( Should be fixed now - thank you for being diligent here :)
Aha, I see! Great that you fixed it. Did you see my other comment regarding "Quad9" vs. "Quad 9"?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r4 (raw file):
Previously, albin-mullvad wrote…
Aha, I see! Great that you fixed it. Did you see my other comment regarding "Quad9" vs. "Quad 9"?
Saw yes, read no. I think the correct form is actually Quad9, as per their own website https://www.quad9.net/about/ .
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r4 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
Saw yes, read no. I think the correct form is actually
Quad9, as per their own website https://www.quad9.net/about/ .
Sounds good to use Quad9! 👍
pinkisemils
force-pushed
the
remove-google-from-default-resolvers-ui
branch
from
33b0a52 to
d5bed21
Compare
pinkisemils
force-pushed
the
remove-google-from-default-resolvers-ui
branch
from
d5bed21 to
1f2e43c
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r6.
Reviewable status:
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
|
🚨 End to end tests failed. Please check the failed workflow run. |
I did a bad by updating the changelog and removing the Google resolvers from the
mullvda-encrypted-dns-proxy. Now I'm cleaning it up and removing it from the UI too. I couldn't find any reference to Google in the android codebase, am I ooking in the right places @albin-mullvad ?This change is