Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure device management screen to hide notification bar #7545

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Configure device management screen to hide notification bar #7545

merged 2 commits into from
Jan 31, 2025

Conversation

acb-mv
Copy link
Contributor

@acb-mv acb-mv commented Jan 29, 2025 •
edited by faern
Loading

This ensures that the "what's new" notice does not appear in the "Too many devices" screen as the user is logging in.

This change is Reviewable

@acb-mv acb-mv self-assigned this Jan 29, 2025
@linear Linear
Copy link

linear bot commented Jan 29, 2025

IOS-1035 Stop displaying in-app banner in non-main view

@acb-mv acb-mv added the iOS Issues related to iOS label Jan 29, 2025
pinkisemils
pinkisemils previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

buggmagnet
buggmagnet previously approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@waahlnaden
Copy link
Collaborator

As mentioned in the stand-up. This needs to be disabled in the out of time view as well.

@acb-mv acb-mv dismissed stale reviews from buggmagnet and pinkisemils via b554e34 January 30, 2025 09:15
rablador
rablador approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@acb-mv
Copy link
Contributor Author

acb-mv commented Jan 30, 2025

Done.

rablador
rablador approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

buggmagnet
buggmagnet approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the IOS-1035-new-version-banner-too-many-devices branch from b554e34 to 0fdc5ec Compare January 31, 2025 08:38
@buggmagnet buggmagnet merged commit fa0f96d into main Jan 31, 2025
10 of 11 checks passed
@buggmagnet buggmagnet deleted the IOS-1035-new-version-banner-too-many-devices branch January 31, 2025 08:40
@github-actions GitHub Actions
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rablador rablador rablador approved these changes

@buggmagnet buggmagnet buggmagnet approved these changes

@mojganii mojganii Awaiting requested review from mojganii

@pinkisemils pinkisemils Awaiting requested review from pinkisemils

Assignees

@acb-mv acb-mv

Labels
iOS Issues related to iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acb-mv @waahlnaden @rablador @pinkisemils @buggmagnet