Hide connection details view based on tunnel status #7534
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion
ios/MullvadVPN/View controllers/Tunnel/ConnectionView/ConnectionView.swift line 41 at r1 (raw file):
.cornerRadius(12) .padding(EdgeInsets(top: 16, leading: 16, bottom: 24, trailing: 16)) .onReceive(connectionViewModel.$tunnelStatus) { _ in
The onReceive block was being triggered before the view model had a chance to update the tunnelState property with the new value. This caused computed properties to work with outdated or incorrect values, leading to a timing issue. By marking showsConnectionDetails as @Published, we ensure that SwiftUI properly observes the value updates and works with the correct, synchronized state.
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
pinkisemils
force-pushed
the
hide-feature-indicators-in-blocked-state-ios-1039
branch
from
b2bcc8d to
3aaafb0
Compare
pinkisemils
deleted the
hide-feature-indicators-in-blocked-state-ios-1039
branch
|
🚨 End to end tests failed. Please check the failed workflow run. |
1 similar comment
|
🚨 End to end tests failed. Please check the failed workflow run. |
This PR toggles the visibility of the connection detail info base on tunnel state.
This change is