Skip to content

Remove MUI X libraries as peer dependencies #4854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Apr 16, 2025

Remove MUI X libraries as peer dependencies, as it's not necessary for them to be.

Addresses MUI Toolpad public roadmap (view)

Closes #4840

@apedroferreira apedroferreira added core Infrastructure work going on behind the scenes scope: toolpad-core Abbreviated to "core" labels Apr 16, 2025
@apedroferreira apedroferreira self-assigned this Apr 16, 2025
@apedroferreira apedroferreira marked this pull request as ready for review April 16, 2025 16:39
@mui-bot
Copy link

mui-bot commented Apr 16, 2025

Netlify deploy preview

https://deploy-preview-4854--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 4a10b69

@bharatkashyap
Copy link
Member

Could this cause issues with people who have v7 X Packages installed in their project separately? Should we keep v7 as our dependency version till v8 is stable?

@Janpot
Copy link
Member

Janpot commented Apr 17, 2025

Could this cause issues with people who have v7 X Packages installed in their project separately?

core v7 and x v7 are incompatible. so they shouldn't use x v7 with toolpad in the first place. if they don't want to use a beta version of x they shouldn't use toolpad. it's more unstable than a beta version of x.

besides all of that. I don't see why two versions of the grid couldn't be together in one project

@apedroferreira apedroferreira merged commit 5a45bf1 into mui:master Apr 17, 2025
15 checks passed
@apedroferreira apedroferreira deleted the fix-x-peer-deps branch April 17, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: toolpad-core Abbreviated to "core"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default installation of toolpad/core@0.14.0 needs additional installation of @mui/x-data-grid
4 participants