[code-infra] Remove clock=fake from describeValidation
#17150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCQuintas
added
test
scope: code-infra
JCQuintas
changed the title
describeValidation
|
Deploy preview: https://deploy-preview-17150--material-ui-x.netlify.app/ |
JCQuintas
commented
Mar 26, 2025
| @@ -154,7 +154,7 @@ const createSection = ({ | |||
| } else { | |||
| if (sectionConfig.maxLength == null) { | |||
| throw new Error( | |||
| `MUI X: The token ${token} should have a 'maxDigitNumber' property on it's adapter`, | |||
| `MUI X: The token ${token} should have a 'maxLength' property on it's adapter`, | |||
There was a problem hiding this comment.
This text seemed wrong, as I couldn't find a maxDigitNumber prop
| setValue(past); | ||
| describe('with fake timers', () => { | ||
| // TODO: temporary for vitest. Can move to `vi.useFakeTimers` | ||
| let timer: SinonFakeTimers | null = null; |
| value: [past, now], | ||
| describe('with fake timers', () => { | ||
| // TODO: temporary for vitest. Can move to `vi.useFakeTimers` | ||
| let timer: SinonFakeTimers | null = null; |
| } | ||
| describeSkipIf(!withDate)('with fake timers', () => { | ||
| // TODO: temporary for vitest. Can move to `vi.useFakeTimers` | ||
| let timer: SinonFakeTimers | null = null; |
flaviendelangle
approved these changes
Mar 27, 2025
LukasTy
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are improvements made during the
vitestPRI'm moving the changes out so that PR is leaner.
The main change here is removing the fake date usage from most of the
describeValidationlogic.I've left it only where necessary, in the
should apply disablePasttestsAn alternative would be to always fake the date, which would probably work, but I preferred a more precise approach.