[ScrollArea] Handle visibility change and nesting #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
the
component: scroll area
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: atomiks <cc.glows@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
|
There's an issue when the viewport is resized while the Select is open. Once the viewport edge reaches the thumb, the native scrollbar appears. select-scroll.mov |
|
@michaldudak updated - looks like that's just because |
atomiks
force-pushed
the
fix/scroll-area-hide-nesting
branch
from
608f838 to
ffbbf54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ScrollArea inside Select, all the wrappers need
role="presentation"to not interfere with thelistboxrole.Further, the thumb was not computed when the ScrollArea became visible, and incorrectly reset the scrollbar offset if it had no width/height (such as on hide/unmount).
https://deploy-preview-1598--base-ui.netlify.app/experiments/scroll-area/inside-select