Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using assigned shortcut to open or save results #1410

Open
1 of 5 tasks
YouRik opened this issue Dec 8, 2024 · 0 comments
Open
1 of 5 tasks

Error when using assigned shortcut to open or save results #1410

YouRik opened this issue Dec 8, 2024 · 0 comments
Labels

Comments

@YouRik
Copy link

YouRik commented Dec 8, 2024

Describe the bug
Assigning a shortcut and using it to open or save the results yields a Can't find active results view error and does not execute the desired action. It can, however, be executed by pressing the respective button in the results view.

The SQLTools output channel log shows: INFO (ext): EXECUTING COMMAND => sqltools.openResults without any other information. The webview developer console also shows no additional output.
However, in the bottom right, a notification pops up saying Can't find active results view.

To Reproduce
Steps to reproduce the behavior:

  1. Assign a shortcut to command sqltools.openResults (or sqltools.saveResults), e.g. cmd+e cmd+o
  2. Connect to a database
  3. Run a query that returns a result, like a simple SELECT * FROM <table>;
  4. Observe that the results view opens
  5. Press assigned shortcut (cmd+e cmd+o)
  6. Observe that, depending on the settings, the results do not open in csv (or json), neither does the prompt to ask for csv or json. Instead, a notification pops up in the bottom right saying: Can't find active results view
  7. Observe that pressing the button in the results view does open and export/save the output correctly as csv/json.

Expected behavior
Shortcut assigned to open/save results command should behave exactly the same as pressing the respective button in the results view.

Screenshots
N/A

Desktop (please complete the following information):

  • SQLTools Version: v0.28.3
  • VS Code Version: 1.95.3
  • OS: Mac
  • Driver:
    • PostgreSQL/Redshift
    • MySQL/MariaDB (untested)
    • MSSQL/Azure (untested)
    • SQLite (untested)
    • Other? Which... (untested)
  • Database version: PostgreSQL 16.2

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant