feat: add intrinsic support for SOCKS proxies #1966
+842
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirtyHairy
changed the title
robertsLando
requested changes
Feb 6, 2025
src/lib/connect/index.ts
Outdated
Comment on lines
107
to
118
| if (isBrowser || opts.unixSocket) { | ||
| opts.socks = undefined | ||
| } | ||
|
|
||
| if ( | ||
| !isBrowser && | ||
| !opts.unixSocket && | ||
| opts.socks === undefined && | ||
| typeof process !== 'undefined' | ||
| ) { | ||
| opts.socks = process.env['MQTTJS_SOCKS_PROXY'] | ||
| } |
There was a problem hiding this comment.
why? Could you remove the env var here?
There was a problem hiding this comment.
I added the environment variable in order to provide an easy way to route unmodified applications that use mqtt.js through a proxy. In or case the culprit is Node-RED.
It would be definitely preferable if these had support for using a proxy themselves, but configuring a proxy is one of those networking options where it is not uncommon to offer configuration through the environment.
robertsLando
reviewed
Feb 6, 2025
robertsLando
requested changes
Feb 6, 2025
|
@DirtyHairy Would it be possible to test part of this? |
|
Sure, done 😏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for establishing TCP and TLS connections through a SOCKS proxy. Proxy support is enabled with a new
socksconfiguration parameter that takes a curl-style SOCKS URL, or by setting an environment variable (MQTTJS_SOCKS_PROXY).Supported schemes (and protocols) are
socks5://,socks5h://,socks4://andsocks4a://.