chore: replace standard with eslint+prettier #1638
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| function parseAuthOptions(opts) { | ||
| let matches | ||
| if (opts.auth) { | ||
| matches = opts.auth.match(/^(.+):(.+)$/) |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1638 +/- ##
==========================================
- Coverage 86.39% 86.16% -0.23%
==========================================
Files 19 19
Lines 1264 1272 +8
==========================================
+ Hits 1092 1096 +4
- Misses 172 176 +4
☔ View full report in Codecov by Sentry. |
|
@vishnureddy17 @BertKleewein as expected this has also fix some bugs in code like undefined vars that now are highlighted by eslint. Also everything has a cleaner syntax now using arrow functions |
|
Ready for review now @BertKleewein @vishnureddy17 🙏🏼 |
| @@ -1,27 +1,25 @@ | |||
| 'use strict' | |||
|
|
|||
| const url = require('url') | |||
There was a problem hiding this comment.
Perhaps we could do this everywhere we use a dependency built into node to make things clear. Not sure if this would affect brower compatibility.
| const url = require('url') | |
| const url = require('node:url') |
There was a problem hiding this comment.
I just did a try, seems browserify doesn't support ndoe: protocol yet :( we can keep this maybe for the rollup refactor if we ever find a way to make that work
There was a problem hiding this comment.
Reference: browserify/browserify#2019
There was a problem hiding this comment.
there's no real benefit to using node:; just stick with url.
| if (typeof alias !== 'undefined') { | ||
| if (topic.length === 0) { | ||
| if (alias > 0 && alias <= 0xffff) { | ||
| const gotTopic = |
There was a problem hiding this comment.
nit: I feel like the newline here is not really useful. Maybe increase the max line length setting?
There was a problem hiding this comment.
Line length increesed to 100 (default is 80)
There was a problem hiding this comment.
I reverted this as I found out prettier reccomendations: https://prettier.io/docs/en/options.html#print-width
Fixes #1637
Additional changes:
errorswas not defined inhandlers/authDEBUGenv based on if we are running tests with debug mode enabledthatlintandlint-fixnpm scripts and addedlintto cishould not reconnect if pingresp is successfultest where client connection was not closed properlyauth packetflaky test caused by a race condition (see comment)authPacketclient optionmanualConnectoption to allow user manually callingconnect(previously called_setupStream). This trick is used when user want to setup listeners or other thing before doing the connect. This is used inauth packettest for example to prevent the race condition. Also Fixes Manual connect #1496I also tried to fix the mocha
aftermethod intest/clientandtest/unique_message_id_provider_client. It actually callsserver.close()without checking if there are open sockets (connections). I did a change to keep a reference of all sockets and close them before server.close and calldonecallback provided byafteron server close. I also tried to change the code using afterEach and beforeEach so the server is created and closed before and after each test (as I think should be) but that doesn't work too.