fix: forward Impressions and Promotions custom attributes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are added different files for some reason will review back |
|
My bad, I think its adding some other code because merging with |
|
re-opening now that |
|
reviewed with @mmustafa-tse live on zoom and he showed me E2E testing results. |
rmi22186
reviewed
Aug 19, 2024
| ProductImpressions: [ | ||
| { | ||
| // TODO: Does this map to the name or id of the impression? | ||
| ProductImpressionList: 'Related Products', |
There was a problem hiding this comment.
This will be the name of the impression
There was a problem hiding this comment.
removed the TODO as mentioned
rmi22186
approved these changes
Aug 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
## [1.4.4](v1.4.3...v1.4.4) (2024-08-20) ### Bug Fixes * forward Impressions and Promotions custom attributes ([#60](#60)) ([d13f694](d13f694))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
same issue as this PR for the Android, where custom attributes for both impression and promotion events don't forward. Right now the only kit that forwards them is the iOS GA4 Firebase kit
Testing Plan
Master Issue
Closes https://mparticle-eng.atlassian.net/browse/PRODRDMP-7123