This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Remove X-XSS-Protection grading entirely.
#490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarron
force-pushed
the
remove-x-xss-protection
branch
from
2a2b395 to
67ae1cb
Compare
This addresses mozilla/http-observatory-website#254 To quote https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection : > ### Warning: > > Even though this feature can protect users of older web browsers that > don't yet support CSP, in some cases, XSS protection can create XSS > vulnerabilities in otherwise safe websites. See the section below for > more information. > > ### Note: > > - Chrome has removed their XSS Auditor > - Firefox has not, and will not implement X-XSS-Protection > - Edge has retired their XSS filter The cited "section below" provides a concrete example of how the XSS filter can be harmful: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection#vulnerabilities_caused_by_xss_filtering This PR is a very simple strawperson. It might be worth doing one of the following instead: - Recognizing possible header values without giving them a score. - Recognizing certain header values as reasonable, such as `block`. - Not grading the header, but putting some sort of notice if the header was observed, e.g. "The Mozilla TLS Observatory used to grade the `X-XSS-Protection` header, but this is no longer the case. For details, see: [link here]"
lgarron
force-pushed
the
remove-x-xss-protection
branch
from
67ae1cb to
31c2b07
Compare
|
This is being handled with #520, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses mozilla/http-observatory-website#254
To quote https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection :
The cited "section below" provides a concrete example of how the XSS filter can be harmful: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection#vulnerabilities_caused_by_xss_filtering
This PR is a very simple strawperson. It might be worth to select a more "informational" alternative:
block.X-XSS-Protectionheader, but this is no longer the case. For details, see: [link here]"