fix: fail fast if attempting to validate empty hostname

mozilla · Jan 5, 2024 · 66b200b · 66b200b
1 parent fd7557d
commit 66b200b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/httpobs/website/api.py b/httpobs/website/api.py
@@ -26,11 +26,13 @@ def api_post_scan_hostname():
     # TODO: Allow people to accidentally use https://mozilla.org and convert to mozilla.org
 
     # Get the hostname
-    hostname = request.args.get('host', '').lower()
+    hostname = request.args.get('host', '').lower().strip()
 
     # Fail if it's not a valid hostname (not in DNS, not a real hostname, etc.)
     ip = True if valid_hostname(hostname) is None else False
-    hostname = valid_hostname(hostname) or valid_hostname('www.' + hostname)  # prepend www. if necessary
+    hostname = valid_hostname(hostname) or (
+        valid_hostname('www.' + hostname) if hostname else False
+    )  # prepend www. if necessary
 
     if ip:
         return {