Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to hide the fence badges #395

Open
TheoChevalier opened this issue May 23, 2019 · 10 comments
Open

Add the ability to hide the fence badges #395

TheoChevalier opened this issue May 23, 2019 · 10 comments
Labels
needs-priority This issue needs prioritization

Comments

@TheoChevalier
Copy link
Contributor

Hi there,

Is there a way to hide the fence badges in v1.9 without disabling the add-on entirely (even by setting a pref value)? I’m hitting a few cases where the badges are displayed and it’s a big no-no :/

  1. Some French catch-up TV websites, like https://www.6play.fr

Badges stay over the content while streaming with no way to remove them
Screenshot_2019-05-23 19 45 du mercredi 22 mai - 6play

  1. ProtonMail. When you open an email containing a Facebook tracker, the badge gets displayed, and even if you open other emails, it stays in the way.

Screenshot_2019-05-23 (312) Boîte de réception ProtonMail

I’m assuming I’ll hit other cases like this, so I think allowing people to hide them would be great.

Thanks!

@maxxcrawford
Copy link
Collaborator

Yes! We’re working internally on implementing this in one of the next immediate releases. We should land something as early as the next two weeks. 😸

@AeonEternum
Copy link

Gets more interesting on imgur.com: https://i.imgur.com/UWKfhyc.jpg
Thank you!

@TheUnixDude
Copy link

Any update on this?

@maxxcrawford
Copy link
Collaborator

maxxcrawford commented Jul 26, 2019

@TheUnixDude Our latest release included only showing one single badge per page and it only displays on visible items. This isn't a direct solution to this issue, but it does solve some use cases. Do you have a specific site with this issue?

@TheUnixDude
Copy link

Thanks for the reply.

(Firefox 68.0.1, Debian Stable, plugin version 2.0.1)

On pretty much any page I visit which both triggers the plugin and has content requiring lots of vertical scrolling (think: reddit, various new sites, imgur, or similar), the scrolling causes the icon to hover over various parts of the page; it's a good 1-2 seconds of activity behind whatever I'm doing, as if the icon refresh rate is 1s or so. Eventually it will settle on the offending item in the page if I stop scrolling.

I'd prefer to simply not have any visible indication in the content at all - if the plugin works, I don't need a red icon bouncing over my content reminding me. A simple color change of the plugin icon in the Firefox bar (ala UBlock Origin, Privacy Badger, etc) would be more than sufficient.

@kparal
Copy link

kparal commented Jul 26, 2019

I also find the badge unnecessarily distracting, especially during scrolling. I don't see the point of the badge, except for self-promoting (it's the same reason why software (think antivirus, etc) often keep an animated icon in Windows systray during almost any activity - it has almost zero informational value for users and just distracts them, but makes sure they are aware of the product, therefore strengthening the brand). I installed the extension and expect it to work. I want to know when it doesn't work for some reason, and not every time it does. I would very much prefer to disable the badge completely. Thank you for consideration. (Please note that I very much appreciate you working on this. It's just the current presentation that I don't enjoy).

@AeonEternum
Copy link

I swear I read somewhere that a toggle is planned for the icon.

Gets more interesting on imgur.com: https://i.imgur.com/UWKfhyc.jpg
Thank you!

Anyhow, I left this comment on May 28th and it has since gotten better. In most cases I see either none or only 1 icon when browsing imgur.

@theprojectsomething
Copy link

theprojectsomething commented Sep 15, 2019

Just to add to this: IMO leaving the current implementation as the default setting is fine; it's important new installs visually showcase how the add-on works (in-situ reminders of broken features are important, and especially for new Firefox users who may have come across on the back of the privacy campaign). However, customisation is sorely missing. This includes the ability to dismiss warnings (i.e. icons) and e.g. easily add the site you're on to the FB container.

@Pfaufisch
Copy link

@TheUnixDude Our latest release included only showing one single badge per page and it only displays on visible items. This isn't a direct solution to this issue, but it does solve some use cases. Do you have a specific site with this issue?

Video player of the New York Times is broken. Any interaction with the player (turning on HD, pressing play/pause) has the icon appearing and sticking on top of the player, even when the UI fades out.

Bildschirmfoto 2019-12-11 um 22 42 18

@maxxcrawford
Copy link
Collaborator

Feature for #550

@maxxcrawford maxxcrawford added P2 should fix before shipping and removed 2.1-p2 labels Jun 25, 2020
@maxxcrawford maxxcrawford added needs-priority This issue needs prioritization and removed P2 should fix before shipping labels Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-priority This issue needs prioritization
Projects
None yet
Development

No branches or pull requests

8 participants