-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support ManuallyDrop
, MaybeUninit
and Box
as simplified types for C only
#578
Closed
Closed
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
32470a8
feat(parser,ir) Declare `ManuallyDrop` as a simplified type.
Hywan 4e37d26
test: Test `ManuallyDrop` as a simplified type.
Hywan 94f64e7
feat(parser,ir) Declare `MaybeUninit` as a simplified type.
Hywan edbd48b
test: test `MaybeUninit` as a simplified type.
Hywan 3c1f990
test: Lint Rust code.
Hywan 8e42a71
feat(ir) Simplify `ManuallyDrop` and `MaybeUninit` only for C.
Hywan 7571296
test: Support a new `.skip_cpp` test suffix.
Hywan ece9627
test: Skip CPP for the `manuallydrop` and `maybeuninit` test cases.
Hywan d925991
feat: Simplify `Box<T>` to `*T` for C only.
Hywan fa2da63
test: Ensure `Option<Box<T>>` reduces to `*T`.
Hywan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
#include <stdarg.h> | ||
#include <stdbool.h> | ||
#include <stdint.h> | ||
#include <stdlib.h> | ||
|
||
typedef struct NotReprC_Box_i32 NotReprC_Box_i32; | ||
|
||
typedef NotReprC_Box_i32 Foo; | ||
|
||
typedef struct MyStruct { | ||
int32_t *number; | ||
} MyStruct; | ||
|
||
void delete(int32_t *x); | ||
|
||
void root(const Foo *a, const MyStruct *with_box); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#include <stdarg.h> | ||
#include <stdbool.h> | ||
#include <stdint.h> | ||
#include <stdlib.h> | ||
|
||
typedef struct NotReprC_Box_i32 NotReprC_Box_i32; | ||
|
||
typedef NotReprC_Box_i32 Foo; | ||
|
||
typedef struct MyStruct { | ||
int32_t *number; | ||
} MyStruct; | ||
|
||
#ifdef __cplusplus | ||
extern "C" { | ||
#endif // __cplusplus | ||
|
||
void delete(int32_t *x); | ||
|
||
void root(const Foo *a, const MyStruct *with_box); | ||
|
||
#ifdef __cplusplus | ||
} // extern "C" | ||
#endif // __cplusplus |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
#include <stdarg.h> | ||
#include <stdbool.h> | ||
#include <stdint.h> | ||
#include <stdlib.h> | ||
|
||
typedef struct NotReprC_Box_i32 NotReprC_Box_i32; | ||
|
||
typedef NotReprC_Box_i32 Foo; | ||
|
||
typedef struct { | ||
int32_t *number; | ||
} MyStruct; | ||
|
||
void delete(int32_t *x); | ||
|
||
void root(const Foo *a, const MyStruct *with_box); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#include <stdarg.h> | ||
#include <stdbool.h> | ||
#include <stdint.h> | ||
#include <stdlib.h> | ||
|
||
typedef struct NotReprC_Box_i32 NotReprC_Box_i32; | ||
|
||
typedef NotReprC_Box_i32 Foo; | ||
|
||
typedef struct { | ||
int32_t *number; | ||
} MyStruct; | ||
|
||
#ifdef __cplusplus | ||
extern "C" { | ||
#endif // __cplusplus | ||
|
||
void delete(int32_t *x); | ||
|
||
void root(const Foo *a, const MyStruct *with_box); | ||
|
||
#ifdef __cplusplus | ||
} // extern "C" | ||
#endif // __cplusplus |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
#include <stdarg.h> | ||
#include <stdbool.h> | ||
#include <stdint.h> | ||
#include <stdlib.h> | ||
|
||
struct NotReprC_Box_i32; | ||
|
||
typedef struct NotReprC_Box_i32 Foo; | ||
|
||
struct MyStruct { | ||
int32_t *number; | ||
}; | ||
|
||
void delete(int32_t *x); | ||
|
||
void root(const Foo *a, const struct MyStruct *with_box); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#include <stdarg.h> | ||
#include <stdbool.h> | ||
#include <stdint.h> | ||
#include <stdlib.h> | ||
|
||
struct NotReprC_Box_i32; | ||
|
||
typedef struct NotReprC_Box_i32 Foo; | ||
|
||
struct MyStruct { | ||
int32_t *number; | ||
}; | ||
|
||
#ifdef __cplusplus | ||
extern "C" { | ||
#endif // __cplusplus | ||
|
||
void delete(int32_t *x); | ||
|
||
void root(const Foo *a, const struct MyStruct *with_box); | ||
|
||
#ifdef __cplusplus | ||
} // extern "C" | ||
#endif // __cplusplus |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
#[repr(C)] | ||
pub struct MyStruct { | ||
number: Box<i32>, | ||
} | ||
|
||
pub struct NotReprC<T> { | ||
inner: T, | ||
} | ||
|
||
pub type Foo = NotReprC<Box<i32>>; | ||
|
||
#[no_mangle] | ||
pub extern "C" fn root(a: &Foo, with_box: &MyStruct) {} | ||
|
||
#[no_mangle] | ||
pub extern "C" fn delete(x: Box<i32>) {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the swift_name_macro check is not correct... Can you elaborate on why you added it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure it was correct. I had no idea what
swift_name_macro
is used for!