Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to chrono 0.4.20 #6636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhammond
Copy link
Member

@mhammond mhammond commented Mar 3, 2025

This is a workaround to bring app-services and mozilla-central into agreement re supported chrono versions. See bug 1951517 for the m-c side of this.

See https://docs.rs/chrono/latest/src/chrono/datetime/mod.rs.html#92-110 - it looks like chrono just decided the "old" name wasn't good enough.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

This is a workaround to bring app-services and mozilla-central into agreement re supported
chrono versions. See bug 1951517 for the m-c side of this.
@mhammond
Copy link
Member Author

mhammond commented Mar 4, 2025

This doesn't work in practice in m-c due to mozilla/glean#3071 - so while I think this patch is fine, I'll keep it open until we can actually upgrade m-c to 0.4.20. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1951517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants