-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1938924 - Add support for search-config-overrides-v2 to the Rust… #6614
Conversation
ba28e3e
to
c5f227f
Compare
I updated the patch to fix the failing tests. I didn't notice them when I first push this up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is a good start and looks like it will fix some more of the desktop tests 🎉
A few things to consider that I've added in-line.
0b57b36
to
8144a73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks good. One comment to consider. AFAIK mobile hasn't landed anything using this yet, so the types.rs change shouldn't need to count as breaking API.
… based search engine selector.
8144a73
to
151fa44
Compare
… based search engine selector.
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[firefox-android: branch-name]
to the PR title.