Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1938924 - Add support for search-config-overrides-v2 to the Rust… #6614

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

mandysGit
Copy link
Contributor

@mandysGit mandysGit commented Feb 26, 2025

… based search engine selector.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@mandysGit mandysGit requested a review from Standard8 February 26, 2025 01:57
@mandysGit mandysGit force-pushed the search-config-overrides-v2 branch from ba28e3e to c5f227f Compare February 27, 2025 02:31
@mandysGit
Copy link
Contributor Author

I updated the patch to fix the failing tests. I didn't notice them when I first push this up.

Copy link
Member

@Standard8 Standard8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a good start and looks like it will fix some more of the desktop tests 🎉

A few things to consider that I've added in-line.

@mandysGit mandysGit force-pushed the search-config-overrides-v2 branch 2 times, most recently from 0b57b36 to 8144a73 Compare March 4, 2025 23:34
@mandysGit mandysGit requested a review from Standard8 March 5, 2025 19:53
Copy link
Member

@Standard8 Standard8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good. One comment to consider. AFAIK mobile hasn't landed anything using this yet, so the types.rs change shouldn't need to count as breaking API.

@mandysGit mandysGit force-pushed the search-config-overrides-v2 branch from 8144a73 to 151fa44 Compare March 7, 2025 05:59
@mandysGit mandysGit added this pull request to the merge queue Mar 7, 2025
Merged via the queue into mozilla:main with commit f0061c1 Mar 7, 2025
15 checks passed
@mandysGit mandysGit deleted the search-config-overrides-v2 branch March 7, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants