Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DISCO-3212] Switch Relevancy to new remote settings API #6601

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[DISCO-3212] Switch Relevancy to new remote settings API #6601

wants to merge 2 commits into from
+231 −103

Conversation

bendk
Copy link
Contributor

@bendk bendk commented Feb 19, 2025 •
edited
Loading

PR notes:

  • The first commit after the other PRs is a refactoring that shouldn't change any functionality
  • The second commit is where the actual changes are.
  • Like [DISCO-3211] Suggest: move to new remote settings API #6598, this is breaking for consumer apps. I think we should merge a smaller PR before this one, see my comment in that PR for details.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@bendk bendk requested review from a team and skhamis February 19, 2025 19:08
@bendk bendk force-pushed the push-lpwnnqtpwork branch 2 times, most recently from c1d9491 to 625f178 Compare February 21, 2025 18:56
bendk added 2 commits February 25, 2025 14:29
@bendk
Add RelevancyStoreInner
5974fdc 
The main reason is that it makes will make it easier to test the code
for DISCO-3212 because we can make `RelevancyStoreInner` generic over
the remote settings client.  In real-world usage, this will store a real
client, but for the tests we can store a test client.

Removed the `calculate_metrics` which was never used.
@bendk
[DISCO-3212] Switch Relevancy to new remote settings API
5dba6b5
@bendk bendk force-pushed the push-lpwnnqtpwork branch from 625f178 to 5dba6b5 Compare February 25, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhamis skhamis Awaiting requested review from skhamis skhamis was automatically assigned from mozilla/a-s-review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bendk