build: upgrade rusqlite 0.31 → 0.33

[ErichDonGubler]

Known outstanding dependencies before merge

• Upgrade Rust MSRV in mozilla-central to 1.82: bug 1945020

• Figure out cc dependency upgrade: bug 1945694

  Current naive upgrade to latest breaks sanitizer builds. 😩

Pull Request checklist

• Breaking changes: This PR follows our breaking change policy
  • This PR follows the breaking change policy:
    • This PR has no breaking API changes, or
    • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
• Quality: This PR builds and tests run cleanly
  • Note:
    • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
    • If this pull request includes a breaking change, consider cutting a new release after merging.
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
  • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
• Dependencies: This PR follows our dependency management guidelines
  • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

[ErichDonGubler]

Context: This is part of landing an upgrade to hashbrown that affects a lot of crates in mozilla-central. I'm hoping the migration isn't too bad. 😅

[mhammond]

This will require bumping libsqlite3-sys to the matching version, which appears to be "0.31.0"

[glandium]

permits a minimum Rust version of 1.78.

Correction, it's 1.76 currently. It's bumpable, but I would also argue that bindgen should not force a MSRV onto people.

[glandium]

I don't see a bindgen change in your patch, though, so why would it start relying on 1.82 features out of the blue?

[glandium]

This comes down to rust-lang/rust-bindgen#3052

[glandium]

Note that if you don't touch bindgen on central, you won't be affected.

[glandium]

Ah, it's the pre-generated bindings for libsqlite3-sys that cause problems.

[glandium]

Opened rusqlite/rusqlite#1625.

[ErichDonGubler]

@glandium: Unfortunately, the maintainer of cc has marked that bug with an invalid tag. It seems unlikely that we will persuade them to revert that change. 🫤

Opened rusqlite/rusqlite#1625.

Given this and that rusqlite is starting to use #[expect(…) (like WGPU has been hoping to), perhaps this is a strong enough reason to bump mozilla-central?

[glandium]

Add the missing symbol to third_party/sqlite3/src/sqlite.symbols

[ErichDonGubler]

With the queuing of patches for an upgrade of the minimum Rust version in mozilla-central to land via bug 1945020, I believe this is now ready to come out of draft, with merging a question of timing with review for the remaining patches in bug 1943149. 😀

[ErichDonGubler]

☝🏻 Given this, it seems the run-tests-min-supported-version check needs to be updated, but is not part of this repo? 🤔

[ErichDonGubler]

@mhammond: The Rust update to 1.82 has been queued for landing (bug 1945020), and we've discovered that the latest versions of cc have breakages that we need to adjust for in mozilla-central. We might be able to work around cc breakage by using a lower version of it here.

Once those are satisfied, I wanted to confirm: @mhammond, is there anything else you see as blocking this PR?

[mhammond]

Because rusqlite is vendored into m-c quite regularly and is done by a variety of teams, I do think we need to be confident that continues to work - ie, I don't think it's OK to land this with a known issue in m-c. But apart from that I'm happy to see this, thanks!

[ErichDonGubler]

@mhammond: I have confirmed that Firefox continues to compile as before with a shim crate adapting a dependency on rusqlite 0.31.0 to actual usage of 0.33.0 for all but application-services crates, which required the migrations present in this PR. I haven't exhaustively tested things, but I suspect things should Just Work™ on the rusqlite front.

[mhammond]

Great, thanks for checking, this seems good to go then!

[ErichDonGubler]

I'll add known outstanding blockers to the OP, so we don't forget that are still blockers with the Rust 1.76 → 1.82 upgrade (which got backed out 😮‍💨) and an upgrade of the cc crate.

The pull request has been modified, dismissing previous reviews.

[ErichDonGubler]

The dependencies for this PR are now satisfied in Firefox upstream! 😀 This PR should be ready to go.

I noticed that dependencies documentation needed changes, even before the substantive changes (!?) of this PR, so I've split out the changes from the output of tools/regenerate_dependency_summaries.sh into a commit before the actual update of rusqlite.

I'm consuming this PR preemptively in the patch stack for bug 1947920, to ensure that things are working as intended downstream.