Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ops agent on all generic worker machines #137

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

bhearsum
Copy link
Contributor

I did test builds of the translations and gw_fxci_gcp_l1 images in my own project. I was able to bring up instances and monitor CPU/RAM/disk on them, which is about as much sanity checking as I can.

@bhearsum bhearsum requested a review from aerickson April 10, 2024 18:34
@bhearsum
Copy link
Contributor Author

For what it's worth, the only images I'm concerned about getting a new version of it in the short term are translations and gw_fxci_gcp_l1. We could wait until we have another reason to rebuild the other ones to pick up this change on them IMO.

@@ -1,5 +1,5 @@
---
project_id: taskcluster-imaging
project_id: bhearsum-test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to land this.

@@ -1,5 +1,5 @@
---
project_id: taskcluster-imaging
project_id: bhearsum-test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to land this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I forgot about my local changes.

@@ -15,5 +15,6 @@ script_directories:
- generic-worker-linux
- worker-runner-linux
- worker-runner-gw-systemd # TODO: merge with 'generic-worker-linux'?
- relops-papertrail-tclogs # needs to run after worker-runner-gw-systemd
# - relops-papertrail-tclogs # needs to run after worker-runner-gw-systemd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Member

@aerickson aerickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aerickson aerickson merged commit 8c5ae7b into mozilla-platform-ops:main Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants