Enable Identity-Aware-Proxy in GCP #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now required in our GCP projects as I understand it.
aerickson
previously approved these changes
Apr 25, 2024
bhearsum
commented
Apr 25, 2024
README.md
Outdated
| @@ -60,6 +61,8 @@ See `monopacker --help` for details. | |||
| You will need to know the builder or builders you want to build; `builder1 builder2` are used in the example here. | |||
|
|
|||
| ```shell | |||
| gcloud auth login # user credentials (every 24 hours) | |||
| gcloud auth application-default login # app credentails (every 24 hours) | |||
There was a problem hiding this comment.
I learned recently that you can get rid of this second line if you add --update-adc to the first one, FYI.
There was a problem hiding this comment.
Aaaah. Awesome. :)
Readme updated.
aerickson
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now required in our GCP projects as I understand it.