moxin-runner: explicitly detect CUDA on Linux #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WasmEdge `install_v2.sh` script currently treats the `--noavx` option as a hard override that bypasses CUDA detection. Thus, we must manually check for CUDA first, and if CUDA is detected, we must *not* pass in the `--noavx` option. We now only pass in the `--noavx` option if CUDA is not found *and* if the CPU doesn't support AVX512. It is not clear what WasmEdge will do if CUDA is detected but the runtime determines that the graphics card is insufficient for its needs -- will it revert back to CPU instructions that require AVX512??
jmbejar
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #200
Ready to merge once #200 is merged.