Skip to content

Commit 0d75af9

Browse files
committed
Formatting improvements in ModelSelector code
1 parent 3f72c0b commit 0d75af9

File tree

1 file changed

+33
-29
lines changed

1 file changed

+33
-29
lines changed

src/chat/model_selector.rs

+33-29
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@ use crate::{
44
};
55
use makepad_widgets::*;
66

7-
use super::{model_selector_list::{ModelSelectorAction, ModelSelectorListWidgetExt}, model_selector_loading::ModelSelectorLoadingWidgetExt};
7+
use super::{
8+
model_selector_list::{ModelSelectorAction, ModelSelectorListWidgetExt},
9+
model_selector_loading::ModelSelectorLoadingWidgetExt,
10+
};
811

912
live_design! {
1013
import makepad_widgets::base::*;
@@ -309,26 +312,23 @@ impl ModelSelector {
309312

310313
fn update_loading_model_state(&mut self, cx: &mut Cx, store: &Store) {
311314
if store.chats.get_loading_model().is_some() {
312-
self.model_selector_loading(id!(loading)).show_and_animate(cx);
315+
self.model_selector_loading(id!(loading))
316+
.show_and_animate(cx);
313317
} else {
314318
self.model_selector_loading(id!(loading)).hide(cx);
315319
}
316320
}
317321

318322
fn update_selected_model_info(&mut self, cx: &mut Cx, store: &Store) {
319-
let Some(downloaded_file) = store.get_loaded_downloaded_file() else {
320-
return;
321-
};
322-
323323
self.view(id!(choose)).apply_over(
324324
cx,
325325
live! {
326326
visible: false
327327
},
328328
);
329329

330-
// When a model is being loaded, show a loading message
331330
if let Some(file) = &store.chats.get_loading_model() {
331+
// When a model is being loaded, show the "loading state"
332332
let caption = format!("Loading {}", file.name);
333333
self.view(id!(selected)).apply_over(
334334
cx,
@@ -340,33 +340,37 @@ impl ModelSelector {
340340
file_size_tag = { visible: false }
341341
},
342342
);
343-
self.redraw(cx);
344-
return;
345-
}
343+
} else {
344+
let Some(downloaded_file) = store.get_loaded_downloaded_file() else {
345+
error!("Error displaying current loaded model");
346+
return;
347+
};
346348

347-
// Normal case when a model is loaded
348-
let filename = downloaded_file.file.name;
349+
// When a model is loaded, show the model info
350+
let filename = downloaded_file.file.name;
349351

350-
let architecture = downloaded_file.model.architecture;
351-
let architecture_visible = !architecture.trim().is_empty();
352+
let architecture = downloaded_file.model.architecture;
353+
let architecture_visible = !architecture.trim().is_empty();
352354

353-
let param_size = downloaded_file.model.size;
354-
let param_size_visible = !param_size.trim().is_empty();
355+
let param_size = downloaded_file.model.size;
356+
let param_size_visible = !param_size.trim().is_empty();
355357

356-
let size = format_model_size(&downloaded_file.file.size).unwrap_or("".to_string());
357-
let size_visible = !size.trim().is_empty();
358+
let size = format_model_size(&downloaded_file.file.size).unwrap_or("".to_string());
359+
let size_visible = !size.trim().is_empty();
360+
361+
self.model_selector_loading(id!(loading)).hide(cx);
362+
self.view(id!(selected)).apply_over(
363+
cx,
364+
live! {
365+
visible: true
366+
label = { text: (filename) }
367+
architecture_tag = { visible: (architecture_visible), caption = { text: (architecture) }}
368+
params_size_tag = { visible: (param_size_visible), caption = { text: (param_size) }}
369+
file_size_tag = { visible: (size_visible), caption = { text: (size) }}
370+
},
371+
);
372+
}
358373

359-
self.model_selector_loading(id!(loading)).hide(cx);
360-
self.view(id!(selected)).apply_over(
361-
cx,
362-
live! {
363-
visible: true
364-
label = { text: (filename) }
365-
architecture_tag = { visible: (architecture_visible), caption = { text: (architecture) }}
366-
params_size_tag = { visible: (param_size_visible), caption = { text: (param_size) }}
367-
file_size_tag = { visible: (size_visible), caption = { text: (size) }}
368-
},
369-
);
370374
self.redraw(cx);
371375
}
372376

0 commit comments

Comments
 (0)