Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for more complicated server params #50

Closed
djoodle opened this issue Jul 8, 2021 · 3 comments
Closed

Support for more complicated server params #50

djoodle opened this issue Jul 8, 2021 · 3 comments

Comments

@djoodle
Copy link

djoodle commented Jul 8, 2021

Hi,

We use envoy in our service mesh - so to communicate to any of the upstream services we do it via the same URL and modify a header (to identify the targeted cluster). Seems like supporting more custom configurations per service could be useful (e.g. adding headers), but couldn't see how I cold configure that with bramble.

Is this possible/do you have an example?

If not could is this something you'd consider as a feature request?

Cheers!

@sodabrew
Copy link

Some services I've worked with have their introspection queries behind API keys, so this would be a useful feature for me as well. Just to test bramble, I hardcoded the extra headers I needed, but before going further I'd want to take the time to break this out into a config setting.

Some questions on use cases and scoping:

  • Would a static set of Header - Value pairs for each server work?
  • Would there need to be an external login flow like for JWT or OAuth?
  • If there's any complicated logic, should that be a plugin written in Go or a generic "execute a script" flow?

@nmaquet
Copy link
Contributor

nmaquet commented Nov 1, 2021

@djoodle @sodabrew This sort of use cases would a lot easier to solve IMHO if Bramble could be imported as a package into a custom application shell. We'll be looking to do something like this for 2.0.

@nmaquet nmaquet closed this as completed Nov 1, 2021
@nmaquet nmaquet added this to the Bramble 2.0 milestone Nov 1, 2021
@nmaquet
Copy link
Contributor

nmaquet commented Nov 7, 2021

See #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants