New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log: removing 'fn' from log line format #37

Merged

felixguendling merged 1 commit into motis-project:master from sncf-connect-tech:logging-rm-fn

Jan 23, 2025

Contributor

Lucas-C commented Jan 23, 2025 •

edited

Loading

Adressing those comments:

For now, I did not include the loc_.function_name() in the log line,
because it can be quite long and IMHO it makes logs harder to read
without providing much valuable information.

I think you were right with the function signature. It's cluttering output a lot. Even if it gives additional context, it's maybe not worth to clutter the text output so much.

This PR should also fix the pipeline: clang-format-18 has been applied to logging_test.cc


          Log: removing 'fn' from log line format

106b27c

felixguendling merged commit d858ae8 into motis-project:master

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet