Significantly speed up applying GTFS-RT updates

With the national feeds from CH, NL and NO the time to process the updates goes down from about a minute to a second here. The cost of this was dominated by vecvec::push_back in rt_timetable::add_rt_transport.
motis-project · Feb 27, 2024 · 53709f2 · 53709f2
1 parent bf9b9e9
commit 53709f2
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/include/nigiri/rt/rt_timetable.h b/include/nigiri/rt/rt_timetable.h
@@ -126,7 +126,8 @@ struct rt_timetable {
   vector_map<bitfield_idx_t, bitfield> bitfields_;
 
   // Location -> RT transports that stop at this location
-  vecvec<location_idx_t, rt_transport_idx_t> location_rt_transports_;
+  mutable_fws_multimap<location_idx_t, rt_transport_idx_t>
+      location_rt_transports_;
 
   // Base-day: all real-time timestamps (departures + arrivals in
   // rt_transport_stop_times_) are given relative to this base day.

diff --git a/src/rt/create_rt_timetable.cc b/src/rt/create_rt_timetable.cc
@@ -12,7 +12,6 @@ rt_timetable create_rt_timetable(timetable const& tt,
   rtt.bitfields_ = tt.bitfields_;
   rtt.base_day_ = base_day;
   rtt.base_day_idx_ = tt.day_idx(rtt.base_day_);
-  rtt.location_rt_transports_.resize(tt.n_locations());
   return rtt;
 }
 

diff --git a/test/routing/rt_routing_test.cc b/test/routing/rt_routing_test.cc
@@ -113,7 +113,6 @@ TEST(routing, rt_raptor_forward) {
   rtt.bitfields_ = tt.bitfields_;
   rtt.base_day_ = date::sys_days{2019_y / May / 3};
   rtt.base_day_idx_ = tt.day_idx(rtt.base_day_);
-  rtt.location_rt_transports_.resize(tt.n_locations());
 
   transit_realtime::FeedMessage msg;
 

diff --git a/test/rt/gtfsrt_resolve_trip_test.cc b/test/rt/gtfsrt_resolve_trip_test.cc
@@ -215,7 +215,6 @@ TEST(rt, gtfs_rt_update) {
   rtt.bitfields_ = tt.bitfields_;
   rtt.base_day_ = date::sys_days{2019_y / May / 3};
   rtt.base_day_idx_ = tt.day_idx(rtt.base_day_);
-  rtt.location_rt_transports_.resize(tt.n_locations());
 
   // Create basic update message.
   transit_realtime::FeedMessage msg;