fix(chai): fix chai assertion typing

morpho-org · Jan 15, 2025 · caa8198 · caa8198
1 parent 371b613
commit caa8198
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 37 deletions.
diff --git a/packages/blue-migration-sdk-viem/test/e2e/aaveV2/supply.test.ts b/packages/blue-migration-sdk-viem/test/e2e/aaveV2/supply.test.ts
@@ -243,11 +243,7 @@ describe("Supply position on AAVE V2", () => {
       expect(bundlerPosition).eql(0n);
       expect(wEthBundlerBalance).eql(0n);
       expect(userPosition).gt(positionAmount - migratedAmount); //interest have been accumulated
-      expect(userMMBalance).approximately(
-        //TODO fix typescript
-        migratedAmount,
-        1n,
-      );
+      expect(userMMBalance).gte(migratedAmount - 2n);
     },
   );
 
@@ -398,11 +394,7 @@ describe("Supply position on AAVE V2", () => {
       expect(bundlerPosition).eql(0n);
       expect(wEthBundlerBalance).eql(0n);
       expect(userPosition).gt(positionAmount - migratedAmount); //interest have been accumulated
-      expect(userMMBalance).approximately(
-        //TODO fix typescript
-        migratedAmount,
-        1n,
-      );
+      expect(userMMBalance).gte(migratedAmount - 2n);
     },
   );
 

diff --git a/packages/blue-migration-sdk-viem/test/e2e/aaveV3/supply.test.ts b/packages/blue-migration-sdk-viem/test/e2e/aaveV3/supply.test.ts
@@ -276,11 +276,7 @@ describe("Supply position on AAVE V3", () => {
         expect(bundlerPosition).eql(0n);
         expect(wEthBundlerBalance).eql(0n);
         expect(userPosition).gt(positionAmount - migratedAmount); //interest have been accumulated
-        expect(userMMBalance).approximately(
-          //TODO fix typescript
-          migratedAmount,
-          1n,
-        );
+        expect(userMMBalance).gte(migratedAmount - 2n);
       });
 
       testFn("Should fully migrate user position", async ({ client }) => {
@@ -435,11 +431,7 @@ describe("Supply position on AAVE V3", () => {
           expect(bundlerPosition).eql(0n);
           expect(wEthBundlerBalance).eql(0n);
           expect(userPosition).gt(positionAmount - migratedAmount); //interest have been accumulated
-          expect(userMMBalance).approximately(
-            //TODO fix typescript
-            migratedAmount,
-            1n,
-          );
+          expect(userMMBalance).gte(migratedAmount - 2n);
         },
       );
 

diff --git a/packages/blue-migration-sdk-viem/test/e2e/aaveV3Optimizer/supply.test.ts b/packages/blue-migration-sdk-viem/test/e2e/aaveV3Optimizer/supply.test.ts
@@ -268,11 +268,7 @@ describe("Supply position on Morpho AAVE V3", () => {
 
       expect(wEthBundlerBalance).eql(0n);
       expect(userPosition).gt(positionAmount - migratedAmount); //interest have been accumulated
-      expect(userMMBalance).approximately(
-        //TODO fix typescript
-        migratedAmount,
-        1n,
-      );
+      expect(userMMBalance).gte(migratedAmount - 2n);
     },
   );
 
@@ -436,11 +432,7 @@ describe("Supply position on Morpho AAVE V3", () => {
 
       expect(wEthBundlerBalance).eql(0n);
       expect(userPosition).gt(positionAmount - migratedAmount); //interest have been accumulated
-      expect(userMMBalance).approximately(
-        //TODO fix typescript
-        migratedAmount,
-        1n,
-      );
+      expect(userMMBalance).gte(migratedAmount - 2n);
     },
   );
 

diff --git a/packages/blue-migration-sdk-viem/test/e2e/blue/borrow.test.ts b/packages/blue-migration-sdk-viem/test/e2e/blue/borrow.test.ts
@@ -372,16 +372,11 @@ describe("Borrow position on blue", () => {
         );
         expect(finalPositionTo.collateral).equal(collateralToMigrate);
         expect(finalPositionFrom.borrowShares).approximately(
-          //TODO fix typescript
           initialPositionFrom.borrowShares -
             finalPositionFrom.market.toBorrowShares(borrowToMigrate),
           2n,
         );
-        expect(finalPositionTo.borrowAssets).approximately(
-          //TODO fix typescript
-          borrowToMigrate,
-          2n,
-        );
+        expect(finalPositionTo.borrowAssets).approximately(borrowToMigrate, 2n);
       });
 
       testFn("should fully migrate borrow position", async ({ client }) => {
@@ -562,7 +557,6 @@ describe("Borrow position on blue", () => {
           MathLib.WAD + slippageFrom,
         );
         expect(finalPositionTo.borrowAssets).approximately(
-          //TODO fix typescript
           expectedBorrowAssets,
           2n,
         );

diff --git a/packages/test/src/vitest/types.d.ts b/packages/test/src/vitest/types.d.ts
@@ -10,5 +10,9 @@ declare global {
       lte(expected: number | bigint | Date): Assertion;
       lt(expected: number | bigint | Date): Assertion;
     }
+    interface CloseTo {
+      // biome-ignore lint/style/useShorthandFunctionType: Chai does it that way
+      (expected: bigint, delta: bigint, message?: string): Assertion;
+    }
   }
 }