Mutable name and symbol (Opt 1) #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
approved these changes
Aug 13, 2024
| @@ -187,6 +187,32 @@ contract MetaMorpho is ERC4626, ERC20Permit, Ownable2Step, Multicall, IMetaMorph | |||
|
|
|||
| /* ONLY OWNER FUNCTIONS */ | |||
|
|
|||
| /// @inheritdoc IMetaMorphoBase | |||
There was a problem hiding this comment.
Suggested change
| /// @inheritdoc IMetaMorphoBase | |
| /// @inheritdoc IMetaMorphoBase | |
| /// @dev The new name should have a size smaller than 32 bytes. |
Note that we can't add this comment to the interface, because this is the interface of OZ in this case
There was a problem hiding this comment.
Is it ok to only allow strings of size < 32 ?
|
This option is lacking events. |
MathisGD
requested review from
adhusson,
Rubilmax,
MerlinEgalite and
Jean-Grimal
|
Closing as we will go for option 3 or 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.