Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial timelock can be zero #19

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

adhusson
Copy link
Contributor

Alternative to #7, initial timelock can be 0-2weeks, and any further change must be >= 24 hours.

@MathisGD
Copy link
Contributor

In the end I don’t think it’s worth adding any complexity to constrain the timelock zero. It’s under timelock anyway, and you can already do really bad stuff under the timelock. I don’t think that we should prevent for timelock specifically

@adhusson
Copy link
Contributor Author

It’s under timelock anyway, and you can already do really bad stuff under the timelock.
What do you mean by this?

I'm OK with keeping an always nullable timelock, but just to clarify the risk scenario I have in mind it's a 2-step process:

  1. Set timelock to 0 by invoking justifiable-at-the-time reasons.
  2. Later, do bad stuff while timelock is at 0.

It separates the step that can be scrutinized from the step that does the attack.

With a min timelock you cannot escape scrutiny.

@MathisGD
Copy link
Contributor

Actually I don't think that you can justify a 0 timelock (withdrawing from markets or reducing caps being not under timelock). So we are fine with the current version IMO

@MathisGD MathisGD changed the base branch from feat/no-share-price-decrease-2 to feat/other-features August 17, 2024 15:45
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also ok with this option in the end

@MathisGD MathisGD self-assigned this Aug 17, 2024
@MathisGD MathisGD merged commit f07d3a4 into feat/other-features Aug 17, 2024
22 checks passed
@MathisGD MathisGD deleted the feat/initial-timelock-can-be-zero branch August 17, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants