Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Certora] Fix timeout on real + lost = total #13

Merged
merged 12 commits into from
Sep 27, 2024
Merged

[Certora] Fix timeout on real + lost = total #13

merged 12 commits into from
Sep 27, 2024

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery commented Aug 14, 2024 •
edited
Loading

This PR fixes #27 because:

  • the rule realPlusLostEqualsTotal now goes through
  • the rule lostAssetsOnlyMovesAfterUpdateWQueueAndLiquidate has been removed as it does not hold, see Add missing tests #23

@QGarchery QGarchery self-assigned this Aug 14, 2024
Base automatically changed from feat/no-share-price-decrease-2 to dev August 18, 2024 17:21
@QGarchery
Copy link
Contributor Author

Transmitted to the Certora team, they are looking into it

@QGarchery QGarchery closed this Aug 28, 2024
@QGarchery QGarchery reopened this Sep 5, 2024
@QGarchery QGarchery mentioned this pull request Sep 5, 2024
Closed
Base automatically changed from dev to main September 26, 2024 07:36
@QGarchery QGarchery marked this pull request as ready for review September 27, 2024 11:28
@QGarchery QGarchery requested a review from MathisGD September 27, 2024 11:28
@MathisGD MathisGD merged commit b2da748 into main Sep 27, 2024
22 checks passed
@MathisGD MathisGD deleted the certora/timeout-real-plus-total branch September 27, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

Assignees

@QGarchery QGarchery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Certora] Fix formal verif of LostAssetsLink
2 participants
@QGarchery @MathisGD